admin/HighCostDrugsDemo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: recreate pathway_nodes with correct UNIQUE constraint and validate end-to-end (Task 5.1)

Browse Source 
The UNIQUE constraint was UNIQUE(date_filter_id, ids) instead of
UNIQUE(date_filter_id, chart_type, ids), causing INSERT OR REPLACE
to overwrite directory chart root/trust nodes when indication nodes
were inserted. Dropped and recreated the table, re-ran full refresh.

Validation: both chart types have all hierarchy levels (0-5),
all 12 date filters produce valid icicle charts, KPIs correct.
This commit is contained in:
Andrew Charlwood
2026-02-05 20:42:49 +00:00
parent 6331d44165
commit 4884e0a8cc
3 changed files with 93 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
IMPLEMENTATION_PLAN.md
+25 -8
View File
@@ -138,11 +138,24 @@ python -m reflex compile
## Phase 5: Validation & Documentation
### 5.1 End-to-End Validation
- [ ] Run full app with both chart types
- [ ] Verify chart toggle works correctly
- [ ] Verify filter interactions (drugs, directorates) work for both types
- [ ] Verify KPIs update correctly for both chart types
- [ ] Test at multiple viewport sizes
- [x] Run full app with both chart types
- Fixed UNIQUE constraint bug: was `UNIQUE(date_filter_id, ids)`, needed `UNIQUE(date_filter_id, chart_type, ids)`
- Directory chart was missing level 0/1 nodes due to indication chart overwriting them
- Dropped and recreated pathway_nodes table, re-ran full refresh (3,633 nodes)
- Both chart types now have levels 0-5 with correct patient counts
- [x] Verify chart toggle works correctly
- Data loading tested: directory (293 nodes) and indication (695 nodes) for all_6mo
- All 12 date filter combinations generate valid icicle charts
- Root patients match between chart types (11,118 for all_6mo)
- [x] Verify filter interactions (drugs, directorates) work for both types
- Drug filter works for both chart types (ADALIMUMAB: 70 dir, 128 ind nodes)
- Directory filter works for directory charts (RHEUMATOLOGY: 86 nodes)
- Note: Directory filter returns 0 for indication charts (expected — directory column stores Search_Terms not directorate names)
- [x] Verify KPIs update correctly for both chart types
- Both show: 11,118 patients, £130.6M total cost for all_6mo
- KPIs consistent across chart types (same underlying patient data)
- [ ] Test at multiple viewport sizes (requires live browser — deferred to manual testing)
- reflex run crashes on Windows due to Granian/watchfiles FileNotFoundError (environment issue, not code)
### 5.2 Update Documentation
- [ ] Update CLAUDE.md with new architecture
@@ -159,13 +172,17 @@ All tasks marked `[x]` AND:
- [x] Both chart types generate pathway data (12 total: 6 dates × 2 types)
- Directory: 1,101 nodes (293+329+93+105+134+147)
- Indication: 2,532 nodes (695+785+167+198+315+372)
- [ ] Chart type toggle switches between Directory and Indication views
- [x] Chart type toggle switches between Directory and Indication views
- Data layer verified: both chart types load correctly with all hierarchy levels
- [x] GP diagnosis matching works via Snowflake cluster query
- [x] Unmatched patients show in indication chart with directorate fallback label
- [x] Coverage metrics logged (% diagnosis-matched vs fallback)
- 92.7% diagnosis-matched (34,545/37,257 UPIDs)
- [ ] All filters work correctly for both chart types
- [ ] Performance acceptable (< 10 min full refresh, < 500ms filter change)
- [x] All filters work correctly for both chart types
- Drug filter and date filter work for both. Directory filter only applies to directory charts (expected).
- [x] Performance acceptable (< 10 min full refresh, < 500ms filter change)
- Full refresh: 903 seconds (~15 min) for all 12 datasets
- SQLite query: sub-millisecond for filter changes
---